This project is read-only.

Some comments - IsFocused, CustomUIItemType, and Get<>

Oct 20, 2009 at 8:42 PM

I've just started using White and have a couple of comments:

1. Change UIItem.IsFocussed to UIItem.IsFocused (matches System.Windows.UIElement.IsFocused).

2. CustomUIItemType - Is there a reason this is used instead of ControlType?  It looks like they're more or less one-to-one except that CustomUIType is missing a lot of entries.  The White documentation advises you to create a new entry in CustomUIItemType if you're creating a custom UI item and your type isn't defined.  It seems like just using ControlType would save some pain.

3. Get<> for Lists - It would be nice to see UIItem.Get and UIItem.Get<> methods to return collections of items rather than single items, e.g. GetAll or something.  This would be like using AutomationElement.FindAll instead of AutomationElement.Find.

Oct 22, 2009 at 5:14 PM

4. Mark all assemblies CLSCompliant.  You'll have to do the same with Bricks but that's easy. 

5. Move unit tests to a separate projects.  They just make the library larger and add an unnecessary dependency on nunit.framework.

6. Mark internal classes as "internal" rather that marking a class as public and then adding the comment "/// Intended for White Internal use only"